Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various dependencies #1251

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Update various dependencies #1251

merged 1 commit into from
Nov 26, 2018

Conversation

reupen
Copy link
Contributor

@reupen reupen commented Nov 23, 2018

Description of change

Updates various dependencies. Change logs:

Checklist

  • Has a new newsfragment been created? Check changelog/README.rst for instructions
  • Have any relevant search models been updated?
  • Have any relevant fixtures (fixtures/test_data.yaml) been updated?
  • Have any relevant select-/prefetch-related field lists in the views and search apps been updated?
  • Has the admin site been updated (for new models, fields etc.)?
  • Has the README been updated (if needed)?

@codecov
Copy link

codecov bot commented Nov 23, 2018

Codecov Report

Merging #1251 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1251   +/-   ##
=======================================
  Coverage     96.7%   96.7%           
=======================================
  Files          239     239           
  Lines         6928    6928           
  Branches       652     652           
=======================================
  Hits          6700    6700           
  Misses         157     157           
  Partials        71      71

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1d3b3...e0ae7de. Read the comment docs.

requirements.txt Outdated
python-dateutil==2.7.5
pytz==2018.7 # via celery, django
pyyaml==3.13
raven==6.9.0
redis==2.10.6 # via django-redis
redis==3.0.1 # via django-redis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing some problems on Export Wins Data, see https://github.com/uktrade/export-wins-data/pull/730

Copy link
Contributor Author

@reupen reupen Nov 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

django-redis 4.10.0 supports redis-py 3.0 (and we aren't using redis-py-cluster here) – we could deploy to UAT or somewhere else first to make sure thing still work though

Copy link
Contributor Author

@reupen reupen Nov 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, kombu has problems with the new redis client as well: celery/kombu#947

I'll keep redis at 2.10.6 and django-redis at 4.9.1.

@reupen reupen merged commit 59f4471 into develop Nov 26, 2018
@reupen reupen deleted the update-deps branch November 26, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants