-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update various dependencies #1251
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1251 +/- ##
=======================================
Coverage 96.7% 96.7%
=======================================
Files 239 239
Lines 6928 6928
Branches 652 652
=======================================
Hits 6700 6700
Misses 157 157
Partials 71 71 Continue to review full report at Codecov.
|
requirements.txt
Outdated
python-dateutil==2.7.5 | ||
pytz==2018.7 # via celery, django | ||
pyyaml==3.13 | ||
raven==6.9.0 | ||
redis==2.10.6 # via django-redis | ||
redis==3.0.1 # via django-redis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing some problems on Export Wins Data, see https://github.com/uktrade/export-wins-data/pull/730
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
django-redis 4.10.0 supports redis-py 3.0 (and we aren't using redis-py-cluster here) – we could deploy to UAT or somewhere else first to make sure thing still work though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind, kombu has problems with the new redis client as well: celery/kombu#947
I'll keep redis at 2.10.6 and django-redis at 4.9.1.
Description of change
Updates various dependencies. Change logs:
https://github.com/andymccurdy/redis-py/blob/master/CHANGES (indirect dependency)Checklist
fixtures/test_data.yaml
) been updated?