Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-consent-data-to-contact-index #5792

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Nov 15, 2024

Description of change

Add consent_data_last_modified to the contact index in opensearch. A future PR is going to use this field for contact searching

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.48%. Comparing base (17a6a1a) to head (2a4ed2b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5792   +/-   ##
=======================================
  Coverage   96.48%   96.48%           
=======================================
  Files        1036     1036           
  Lines       24625    24626    +1     
  Branches     1638     1638           
=======================================
+ Hits        23759    23760    +1     
  Misses        709      709           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade marked this pull request as ready for review November 15, 2024 09:45
@chopkinsmade chopkinsmade requested a review from a team as a code owner November 15, 2024 09:45
@chopkinsmade chopkinsmade merged commit 64b368b into main Nov 15, 2024
7 checks passed
@chopkinsmade chopkinsmade deleted the feature/add-consent-data-to-contact-index branch November 15, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants