Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'notspecificcountry' country_code value #5805

Merged
merged 0 commits into from
Nov 18, 2024

Conversation

baarkerlounger
Copy link
Contributor

Description of change

Resolve: https://sentry.ci.uktrade.digital/organizations/dit/issues/139199/?project=235&query=is%3Aunresolved

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@baarkerlounger baarkerlounger requested a review from a team as a November 18, 2024 15:19
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (4bf8182) to head (75a8d0c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5805      +/-   ##
==========================================
- Coverage   96.48%   96.47%   -0.01%     
==========================================
  Files        1037     1037              
  Lines       24621    24621              
  Branches     1637     1637              
==========================================
- Hits        23755    23754       -1     
- Misses        709      710       +1     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@baarkerlounger baarkerlounger merged this pull request into main Nov 18, 2024
7 checks passed
@baarkerlounger baarkerlounger deleted the great_not_specific_country branch November 18, 2024 15:48
aadam-ali pushed a commit that referenced this pull request Nov 20, 2024
Handle 'notspecificcountry' country_code value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants