Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature CLS2 -1085 Accept any valid string for Eyblead #5852

Conversation

santoshdasa12345
Copy link
Contributor

@santoshdasa12345 santoshdasa12345 commented Dec 11, 2024

Description of change

Similar to #5849, EYB leads were being rejected by the serialiser at ingestion time due to invalid choices for spend, when in reality we hadn't updated our list of choices to match new ones implemented on EYB's side.

To avoid this issue occurring again, it was decided to remove the choice restriction on this field, as well as intent and landing_timeframe.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@santoshdasa12345 santoshdasa12345 changed the title Updated the model and serializer Feature CLS2 -1085 Accept any valid string for Eyblead Dec 11, 2024
@oliverjwroberts oliverjwroberts force-pushed the feature/CLS2-1085-accept-any-valid-string-for-eyblead-spend-intent-landingtimeframes branch from 502e551 to 7772e48 Compare December 11, 2024 21:54
@oliverjwroberts oliverjwroberts marked this pull request as ready for review December 11, 2024 21:58
@oliverjwroberts oliverjwroberts requested a review from a team as a code owner December 11, 2024 21:58
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (0100779) to head (7772e48).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5852   +/-   ##
=======================================
  Coverage   96.60%   96.61%           
=======================================
  Files        1047     1048    +1     
  Lines       24920    24925    +5     
  Branches     1649     1649           
=======================================
+ Hits        24075    24081    +6     
+ Misses        689      688    -1     
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@baarkerlounger baarkerlounger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit unfortunate but pragmatic for now I guess

@oliverjwroberts oliverjwroberts merged commit 35cd2ab into main Dec 12, 2024
7 checks passed
@oliverjwroberts oliverjwroberts deleted the feature/CLS2-1085-accept-any-valid-string-for-eyblead-spend-intent-landingtimeframes branch December 12, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants