Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/dont-delete-consent-files-after-processing #5855

Merged

Conversation

chopkinsmade
Copy link
Contributor

@chopkinsmade chopkinsmade commented Dec 12, 2024

Description of change

The datahub S3 bucket is setup as read only, files are deleted automatically using the lifecycle policy.

Instead of deleting the S3 file at the end of the contact consent ingestion task, leave the file there and change the logic in the task to retrieve the newest file when the task runs

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (7b5fc1a) to head (f805e8e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5855      +/-   ##
==========================================
- Coverage   96.61%   96.61%   -0.01%     
==========================================
  Files        1051     1051              
  Lines       24967    24964       -3     
  Branches     1652     1651       -1     
==========================================
- Hits        24123    24120       -3     
  Misses        688      688              
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chopkinsmade chopkinsmade force-pushed the feature/dont-delete-consent-files-after-processing branch from 05ded3d to 3519352 Compare December 12, 2024 10:12
@chopkinsmade chopkinsmade force-pushed the feature/dont-delete-consent-files-after-processing branch from 3519352 to f805e8e Compare December 12, 2024 10:25
@chopkinsmade chopkinsmade marked this pull request as ready for review December 12, 2024 10:43
@chopkinsmade chopkinsmade requested a review from a team as a code owner December 12, 2024 10:43
@chopkinsmade chopkinsmade merged commit 60b3563 into main Dec 12, 2024
7 checks passed
@chopkinsmade chopkinsmade deleted the feature/dont-delete-consent-files-after-processing branch December 12, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants