Feature/tet 812 ingest stova data #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to connect to s3_processor Tasks cannot pass the s3_processor as it is cannot be pickled.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5866 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 1058 1059 +1
Lines 25178 25201 +23
Branches 1670 1669 -1
=======================================
+ Hits 24333 24356 +23
Misses 689 689
Partials 156 156 ☔ View full report in Codecov by Sentry. |
|
Paused for now, the frontend event expects a "service" and crashes without one. This is not required by the backend. |
Spoke with Tom Aldridge and we are going to create a new service "Stova Event Service" which will be applied to all ingested Stova Events. |
3 tasks
If this environment variable is set in dev machines these tests fail as the test tries to connect to localstack. This prevents this.
baarkerlounger
approved these changes
Dec 20, 2024
santoshdasa12345
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Ingest Stova event data into DataHub
StovaEventmodel which copies it into a DataHubEvent.This uses the new generic ingest app from here: #5847.
Events require a Service which is not provided by Stova, after speaking with Tom Aldridge and we are going to create a new service "Stova Event Service" which will be applied to all ingested Stova Events.
Each row (stova event) will not be updated but the ingested file will be updated with new events so there is no requirement to update the already ingested Stova Events.
Depending on: uktrade/data-hub-frontend#7422 as the service requires being added to the frontend as well.
Checklist
mainbranch?