Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tet 812 add stova service tag #7422

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Dec 20, 2024

Description of change

Add a new event service tag for a new Stova Event Service service. Without it, there is an empty tag shown.
Also fixes a console warning for an invalid prop value.

This is required to be merged and released before: uktrade/data-hub-api#5866

Test instructions

The existing service tags allowing the new (to be released) Stova Event Service to be shown.

Screenshots

Before

Screenshot 2024-12-20 at 12 23 28

After

Screenshot 2024-12-20 at 12 23 37

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@DeanElliott96 DeanElliott96 self-assigned this Dec 20, 2024
Copy link

cypress bot commented Dec 20, 2024

data-hub-frontend    Run #58281

Run Properties:  status check passed Passed #58281  •  git commit 56a1bca134: Use the TAG_COLOURS constant instead of strings
Project data-hub-frontend
Branch Review feature/TET-812-add-stova-service-tag
Run status status check passed Passed #58281
Run duration 08m 29s
Commit git commit 56a1bca134: Use the TAG_COLOURS constant instead of strings
Committer Dean Elliott
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 75
View all changes introduced in this branch ↗︎

@DeanElliott96 DeanElliott96 marked this pull request as ready for review December 20, 2024 12:41
@DeanElliott96 DeanElliott96 requested a review from a team as a code owner December 20, 2024 12:41
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (6d45f0e) to head (56a1bca).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7422      +/-   ##
==========================================
+ Coverage   88.61%   88.62%   +0.01%     
==========================================
  Files        1161     1161              
  Lines       18022    18024       +2     
  Branches     5124     5126       +2     
==========================================
+ Hits        15970    15974       +4     
+ Misses       2052     2050       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeanElliott96 DeanElliott96 merged commit 9450f2c into main Dec 20, 2024
16 checks passed
@DeanElliott96 DeanElliott96 deleted the feature/TET-812-add-stova-service-tag branch December 20, 2024 13:15
chopkinsmade pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants