Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export wins status totals #5919

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

elcct
Copy link
Contributor

@elcct elcct commented Jan 23, 2025

Description of change

This adds export win status totals (counts for confirmed - customer_response__agree_with_win filter). It adds the following to the list response:

{
    ...
    "confirmed": {
        "null": <count of agree_with_win == null>,
        "true": <count of agree_with_win == true>,
        "false": <count of agree_with_win == false>
    }
}

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@elcct elcct requested a review from a team as a code owner January 23, 2025 09:17
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (95c1713) to head (6ca72f7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5919   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files        1076     1077    +1     
  Lines       25320    25329    +9     
  Branches     1669     1669           
=======================================
+ Hits        24474    24483    +9     
  Misses        690      690           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elcct elcct force-pushed the feature/export-wins-status-totals branch from 406c957 to 6ca72f7 Compare February 11, 2025 09:35
@elcct elcct merged commit 8c58d2b into main Feb 11, 2025
7 checks passed
@elcct elcct deleted the feature/export-wins-status-totals branch February 11, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants