Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply and tweak stage validation for site_address_is_company_address field #5939

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

oliverjwroberts
Copy link
Contributor

@oliverjwroberts oliverjwroberts commented Feb 4, 2025

Description of change

Reapplies PR #5928 (commit 51232c9), which also modified the validation for site address fields. These are now only required if site_address_is_company_address is not None.

The only difference is this PR/commit keeps the validation for the actual_uk_regions field.

Updated frontend PR can be found here.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

…ss` field

Reapplies PR #5928 (commit 51232c9), which also modified the validation for site address fields. These are now only required if `site_address_is_company_address` is not None.

The only difference is this commit keeps the validation for the `actual_uk_regions` field.
@oliverjwroberts oliverjwroberts self-assigned this Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (e762bb1) to head (1e675ae).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5939      +/-   ##
==========================================
- Coverage   96.64%   96.64%   -0.01%     
==========================================
  Files        1069     1069              
  Lines       25250    25253       +3     
  Branches     1663     1663              
==========================================
+ Hits        24404    24405       +1     
- Misses        690      691       +1     
- Partials      156      157       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverjwroberts oliverjwroberts merged commit 32aaca7 into main Feb 10, 2025
7 checks passed
@oliverjwroberts oliverjwroberts deleted the feature/CLS2-1175-site-address-field-changes branch February 10, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants