Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opensearch model updates to index fields for subject ui filter and sort #5945

Merged

Conversation

stuart-mindt
Copy link
Contributor

@stuart-mindt stuart-mindt commented Feb 6, 2025

Description of change

Opensearch model updates to index fields for activity page interaction subject filtering and sorting

https://uktrade.atlassian.net/browse/CLS2-76

image
image

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@stuart-mindt stuart-mindt requested a review from a team as a code owner February 6, 2025 08:48
@stuart-mindt stuart-mindt marked this pull request as draft February 6, 2025 08:48
@stuart-mindt stuart-mindt marked this pull request as ready for review February 10, 2025 16:15
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (ce7c202) to head (dfee6fd).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5945   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files        1070     1070           
  Lines       25262    25263    +1     
  Branches     1664     1664           
=======================================
+ Hits        24416    24417    +1     
  Misses        690      690           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuart-mindt stuart-mindt merged commit 06fa5af into main Feb 11, 2025
7 checks passed
@stuart-mindt stuart-mindt deleted the feature/CLS2-76_activity-tab-add-filter-for-subject branch February 11, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants