Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EYB lead sort by modified feature #5953

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

stuart-mindt
Copy link
Contributor

Description of change

Change to the EYB leads search to allow sort by modified date.

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@stuart-mindt stuart-mindt requested a review from a team as a code owner February 13, 2025 09:33
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (06fa5af) to head (324b3b2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5953      +/-   ##
==========================================
- Coverage   96.66%   96.65%   -0.01%     
==========================================
  Files        1077     1077              
  Lines       25330    25330              
  Branches     1669     1669              
==========================================
- Hits        24484    24482       -2     
- Misses        690      691       +1     
- Partials      156      157       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DeanElliott96 DeanElliott96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe a small test to check sorting defaults to -triage_modified or to remove it if not required?

@stuart-mindt stuart-mindt merged commit a2b9325 into main Feb 13, 2025
7 checks passed
@stuart-mindt stuart-mindt deleted the feature/CLS2-1248_eyb-modified-sort branch February 13, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants