Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing modified as default sort for EYB leads #5954

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

stuart-mindt
Copy link
Contributor

@stuart-mindt stuart-mindt commented Feb 14, 2025

Description of change

Removing modified as default sort for EYB leads as it should be created date

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@stuart-mindt stuart-mindt requested a review from a team as a code owner February 14, 2025 10:17
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (a2b9325) to head (52e8340).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5954   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files        1077     1077           
  Lines       25330    25330           
  Branches     1669     1669           
=======================================
  Hits        24482    24482           
  Misses        691      691           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuart-mindt stuart-mindt merged commit 161e21d into main Feb 14, 2025
7 checks passed
@stuart-mindt stuart-mindt deleted the feature/CLS2-1248_eyb-modified-sort-non-default branch February 14, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants