Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/tet 981 stova attendee ingestion fields #5969

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Feb 20, 2025

Description of change

Some attendees are not being ingested so the models have been relaxed with nulls and blanks to reflect the data model from live Stova Attendees.

Any attendees with fields missing which we do require are now skipped and logged as INFO instead of ERROR so sentry alerts are not raised.

Checklist

  • Has this branch been rebased on top of the current main branch?
  • Is the CircleCI build passing?

@DeanElliott96 DeanElliott96 self-assigned this Feb 20, 2025
@DeanElliott96 DeanElliott96 marked this pull request as ready for review February 20, 2025 13:53
@DeanElliott96 DeanElliott96 requested a review from a team as a code owner February 20, 2025 13:53
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering. View full project report here.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (bebfa68) to head (6450cc4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5969      +/-   ##
==========================================
- Coverage   96.65%   96.63%   -0.02%     
==========================================
  Files        1081     1082       +1     
  Lines       25394    25406      +12     
  Branches     1676     1678       +2     
==========================================
+ Hits        24544    24551       +7     
- Misses        694      698       +4     
- Partials      156      157       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeanElliott96 DeanElliott96 merged commit 7f21f1d into main Feb 21, 2025
7 checks passed
@DeanElliott96 DeanElliott96 deleted the bugfix/TET-981-stova-attendee-ingestion-fields branch February 21, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants