-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/tet 981 stova attendee ingestion fields #5969
Bugfix/tet 981 stova attendee ingestion fields #5969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth considering. View full project report here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5969 +/- ##
==========================================
- Coverage 96.65% 96.63% -0.02%
==========================================
Files 1081 1082 +1
Lines 25394 25406 +12
Branches 1676 1678 +2
==========================================
+ Hits 24544 24551 +7
- Misses 694 698 +4
- Partials 156 157 +1 ☔ View full report in Codecov by Sentry. |
Description of change
Some attendees are not being ingested so the models have been relaxed with nulls and blanks to reflect the data model from live Stova Attendees.
Any attendees with fields missing which we do require are now skipped and logged as
INFO
instead ofERROR
so sentry alerts are not raised.Checklist
main
branch?