Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow contact_info field to be nullable to match stova event data #5978

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

DeanElliott96
Copy link
Contributor

@DeanElliott96 DeanElliott96 commented Feb 25, 2025

Description of change

This field is null from Stova and is not required by Data Hub so allow it to be null as well.

Checklist

  • Has this branch been rebased on top of the current main branch?
  • Is the CircleCI build passing?

@DeanElliott96 DeanElliott96 self-assigned this Feb 25, 2025
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (9b2789f) to head (2fb3b87).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5978   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files        1083     1084    +1     
  Lines       25410    25414    +4     
  Branches     1678     1678           
=======================================
+ Hits        24555    24559    +4     
  Misses        698      698           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeanElliott96 DeanElliott96 marked this pull request as ready for review February 25, 2025 10:07
@DeanElliott96 DeanElliott96 requested a review from a team as a code owner February 25, 2025 10:07
Copy link
Contributor

@code-review-doctor code-review-doctor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth considering. View full project report here.

@DeanElliott96 DeanElliott96 merged commit e4c5719 into main Feb 25, 2025
7 checks passed
@DeanElliott96 DeanElliott96 deleted the bugfix/TET-981-contact-info branch February 25, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants