-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update merge_company.py #5979
Update merge_company.py #5979
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5979 +/- ##
==========================================
- Coverage 96.63% 96.62% -0.01%
==========================================
Files 1084 1084
Lines 25414 25414
Branches 1678 1678
==========================================
- Hits 24559 24557 -2
- Misses 698 699 +1
- Partials 157 158 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should definitely be some tests here for the scenarios in the description.
Remove outdated comment Update test_merge_company.py
5de69dc
to
fc2bb36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, think the existing tests and the new ones cover the bases! Just a couple comments to try and prevent flaky tests.
Description of change
Allow for the merge tool to let companies with the
transferred_field
to be included in company mergesManually tested scenarios:
Company_A
(has no merge) merged intoCompany_B
(has no merge)Company_C
(has no merge) merged intoCompany_B
(has transferred_from)Company_D
(has no merge) merged intoCompany_E
(has no merge)Company_E
(has transferred_from) merged intoCompany_B
(has transferred_from)Company_B
(has transferred_from) intoCompany_F
(has no merge)Checklist
Has this branch been rebased on top of the current
main
branch?Explanation
The branch should not be stale or have conflicts at the time reviews are requested.
Is the CircleCI build passing?
General points
Other things to check
fixtures/test_data.yaml
is maintained when updating modelsSee docs/CONTRIBUTING.md for more guidelines.