Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logging for company merge command #5981

Merged
merged 6 commits into from
Mar 3, 2025
Merged

Conversation

bau123
Copy link
Contributor

@bau123 bau123 commented Feb 28, 2025

Description of change

Update company merge command to include additional logs for:

  • Source Companies with subsidiaries
  • Target Companies archived
  • Source Companies with global_headquarters

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.63%. Comparing base (945e140) to head (09d2c65).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5981   +/-   ##
=======================================
  Coverage   96.63%   96.63%           
=======================================
  Files        1084     1084           
  Lines       25420    25438   +18     
  Branches     1678     1681    +3     
=======================================
+ Hits        24564    24583   +19     
+ Misses        699      698    -1     
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bau123 bau123 marked this pull request as ready for review March 3, 2025 09:47
@bau123 bau123 requested a review from a team as a code owner March 3, 2025 09:47
@bau123 bau123 requested a review from baarkerlounger March 3, 2025 12:14
@bau123 bau123 merged commit 6f66936 into main Mar 3, 2025
7 checks passed
@bau123 bau123 deleted the update-company-merge-logging branch March 3, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants