Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[For discussion] SCIM move back to core #60

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

marcelkornblum
Copy link
Contributor

@marcelkornblum marcelkornblum commented Jan 9, 2025

Here's what it would look like

Arguments for:

  • All APIs are collected together
  • APIs act as the "view" part of the top level core app
  • less top level project congestion; fewer apps, fewer top level folders etc
  • we can avoid breaking the "only core imports from sub apps not the other way around" rule

Arguments against:

  • core gets more in it; it gets fuller
  • our APIs dont feel as significant
  • maybe each of our APIs needs a specific app (not sure if you see this as a con but look at IDPF-196 SSO Profile API GET endpoint #59 to see if you agree that merits an app)

@0RWilliams
Copy link
Contributor

SCIM schemas are store at core.schemas.scim and used in core.api.scim, this looks fine but ProfileMinimal is stored at profiles.schemas and used in core.api.sso_profile.

Is this the plan, or will sso_profile be moved to match scim?

@marcelkornblum
Copy link
Contributor Author

Is this the plan, or will sso_profile be moved to match scim?

This was deliberate but I'm open to discussion about it. The thinking was that SCIM schemas relate to both User and Profile and are therefore core or I guess "Identity" level, where the profile is more specifically for the profile. I felt weird putting the new API inside the profile app but maybe it belongs there.

Either way I understand the discomfort around it, this was my attempt at the right solution but interested to debate it. Might be good to try out any proposals with a couple of strawman APIs that could appear in the future (PF will need an "edit my PF profile one, and we will presumably have a different / more generic one for e.g. Data Hub to get its info from)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants