One Login Integration #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @chris-pettinga, I've managed to look through majority of this PR. I still can't seem to access the viewer portal on dev:
so will probably need to fix that before merging. But otherwise it's looking good!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 89.27% 89.26% -0.01%
==========================================
Files 88 95 +7
Lines 2908 3139 +231
==========================================
+ Hits 2596 2802 +206
- Misses 312 337 +25 ☔ View full report in Codecov by Sentry. |
jenriordan
reviewed
Jan 7, 2025
tests/test_unit/test_apply_for_a_licence/test_views/test_email_verify_views.py
Show resolved
Hide resolved
morganmaerees
approved these changes
Jan 10, 2025
# Conflicts: # django_app/config/settings/local.py # tests/test_frontend/test_feedback/test_collect_feedback.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DST-864
DST-865