Skip to content

Commit

Permalink
Minor refactoring
Browse files Browse the repository at this point in the history
  • Loading branch information
ullenius committed Apr 20, 2024
1 parent 5fbf840 commit 7707878
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ Noncharacters in utf-8 are disallowed for security reasons.

Most of the existing tools are 15-20 year old legacy Windows programs that won't run on modern computers. The source code is lost. Or it was written in C/C++ for 32-bit architecture and won't compile on modern 64-bit computers.

Java is multi-platform and you can run and compile 20-year old Java programs without any issues. So I'd figure this would be a suitable platform for posterity.
Java is multi-platform and you can run and compile 20-year-old Java programs without any issues. So I'd figure this would be a suitable platform for posterity.

Hopefully doing it in Java makes it easy to convert to XML and JSON, as well as persisting it in databases using SQL.

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/se/anosh/spctag/dao/SpcFileReader.java
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ private boolean containsID666Tags() throws IOException {
*/
private boolean hasBinaryTagFormat() throws IOException {
final char first = parse(Id666.Field.ARTIST_OF_SONG_BINARY_FORMAT,
(bytes) -> new String(bytes, StandardCharsets.UTF_8)) // FIXME re-write algorithm
(bytes) -> new String(bytes, StandardCharsets.UTF_8)) // TODO re-write algorithm
.charAt(0);
// If 0xB0 is *NOT* a valid char or *IS* a digit then don't allow it.
// Sometimes we have valid digits in this offset (if the tag-format is text)
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/se/anosh/spctag/domain/Xid6.java
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public Integer getEndLength() {
}

public void setEndLength(int endLength) {
this.endLength = (endLength);
this.endLength = endLength;
}

public Long getFadeLength() {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/se/anosh/spctag/util/Utf8ValidatorTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ void validUtf8TestFile() throws IOException {

@Test
/*
* A contiguous range of 32 noncharacters: U+FDD0..U+FDEF in the BMP
* "A contiguous range of 32 noncharacters: U+FDD0..U+FDEF in the BMP"
* https://www.unicode.org/faq/private_use.html#noncharacters
*
* Tests 32/66 noncharacter
Expand Down

0 comments on commit 7707878

Please sign in to comment.