-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: dbus helper for modules #1547
Conversation
Cool thanks a lot. Mind you we finish we #1546 first? |
Ok then here, can we go for the same |
I'm not sure that works because dbus is quite specific and has a whole interface eg calling methods, getting properties, as well as subscribing to events. think - |
hmm on a second thought indeed this sounds more like the first implementation I made of udev... |
@tobes do you intend to work on this some more ? I might have time to work on it if it's fine with you... |
@boucman by all means, go ahead mate 👍 |
Timeout, closing, reopen if needed mates; Thanks! |
Well, I had a look and honestly it looked good as is... i'm not sure what needs to be added... |
though I should have said so.. |
can you merge this? dbus support would be useful for my plugin... |
@tex no I'm sorry, some modules like |
@ultrabug Thanks! That is exactly what I was looking for! |
#1546 adds cool udev support
this adds dbus support for modules - the code is still in crude proof of concept form.
The example module is battery_level and it just updates on a dbus power change. Due to how the module currently works it triggers better when we unplug the power than when we plug it in. This is more about the module.
It is very crude and needs more work but I wanted to show the code as relates to #1546 so I think it is good to consider the needs of both
The idea of this is
but the real issue for now is how modules interact with this and how it fits in with udev