Meshgrid indexing='ij' for PyTorch 1.10
#5309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will not merge currently as breaks backwards compatibility.
|
/rebase |
Will not merge currently as breaks backwards compatibility.
glenn-jocher
force-pushed
the
update/meshgrid_indexing
branch
from
9c77dcf to
8c0b0ae
Compare
…pdate/meshgrid_indexing # Conflicts: # models/yolo.py
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* Meshgrid `indexing='ij'` for PyTorch 1.10 Will not merge currently as breaks backwards compatibility. * Meshgrid `indexing='ij'` for PyTorch 1.10 Will not merge currently as breaks backwards compatibility. * Add check_version hard argument * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not merge currently as breaks backwards compatibility.
EDIT: added if statement based on torch version to maintain torch>=0.7 compatibility.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improvement of version checking in YOLOv5 with backward compatibility handling.
📊 Key Changes
check_versionfunction call inyolo.pyfor grid creation compatible with PyTorch versions >=1.10.0.albumentationslibrary inaugmentations.py.check_versionfunction ingeneral.pyto include an option to enforce hard version checks.🎯 Purpose & Impact
meshgridfunction, maintaining compatibility with different versions. 🔄