MySQL: utf8mb4? #1264
Comments
|
Related to #1261. We need to update the migration file. Will track there. |
mikecao
added a commit
that referenced
this issue
Jul 7, 2022
johonathan
added a commit
to johonathan/umami
that referenced
this issue
Jul 25, 2022
* Update NL language * Fix check criteria. * Clean-up. * Updated packages. * Updated language bundle. * optimize queries * fix comments * Adds support for `customCollectEndpoint` * Replace `/api/collect` with collectEndpoint * Better logic * Change `API_COLLECT_ENDPOINT` to `COLLECT_API_ENDPOINT` * Unify database changes. Closes umami-software#1264 * Added handling for BigInt values. * Upgraded Next to 12.2.0. * Moved middleware. * Add Filter to Have Direct Referrer * Update lib/filters.js Co-authored-by: Rohan Deb Sarkar <[email protected]> * Update Blank Referrer Text I think this capitalization and spacing looks better after looking at it again. * Updated & Fixed Danish Language I have changed some sentences which were not correcly translated, and not even translated. * Changed a big letter to a small * Missed a couple of words * move queries * fix imports * remove unused index * fix import * add query optimizations from um-13 * Upgrade to Prisma 4. * checkpoint * checkpoint * fix bigint ui * Feature: Add screensize to UI * Allow custom release URL. * Update lang. Remove node 12 test. * Update docker urls. * Updated packages. Bump version v1.34.0. * Added missing package. * Update zh-CN.json * Updated language bundles. * fix(i18n): update norwegian translation * Bump terser from 5.12.0 to 5.14.2 Bumps [terser](https://github.com/terser/terser) from 5.12.0 to 5.14.2. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/commits) --- updated-dependencies: - dependency-name: terser dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Updated packages. Prisma 4.1.0. * Updated language bundle. * convert analytics queries * Refactored referrer logic. Display stats for no referrers. * Fix issue with unicode filtering. Closes umami-software#1258 * Update zh-CN.json * Update fr-FR.json Some french language updates * Update nl-NL.json Some missing translations have been added. * Update the links for current repository * Update zh-CN.json * Reverted getDateQuery logic. * Add UTM pageview metrics to API * Add UTM params to website details page * Fix UTM query, move filters to proper place * Fix tracker build for COLLECT_API_ENDPOINT. * Remove unused prop on UTM table * Update language bundles. * Fixed date query for MySQL. * Bump version v1.35.0 * Update zh-CN.json * Add MySQL support for SQL replacer function * follow-up - reverted getDateQuery logic * clickhouse inserts * Updated language bundles. * fix timer * fix stats query * fix parseFilters * Removed subquery. * PR comments * Fix filter issue for metrics. Closes umami-software#1268 * Bump version 1.36.0 * Update zh-CN.json * Update pl-PL.json * umami-software#1340 : Fix when session received is not an array, but the direct object * Bump version v1.36.1. * Remove foreign keys to support PlanetScale Co-authored-by: Marc Hagen <[email protected]> Co-authored-by: Mike Cao <[email protected]> Co-authored-by: Mike Cao <[email protected]> Co-authored-by: Brian Cao <[email protected]> Co-authored-by: rohandebsarkar <[email protected]> Co-authored-by: Nicholas Fasching <none> Co-authored-by: Nicholas Fasching <[email protected]> Co-authored-by: Rohan Deb Sarkar <[email protected]> Co-authored-by: Fredrik Johansen <[email protected]> Co-authored-by: Tobias Hüske <[email protected]> Co-authored-by: liaohongxing <[email protected]> Co-authored-by: Sigve Hansen <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Lemonawa <[email protected]> Co-authored-by: Clément Radenac <[email protected]> Co-authored-by: Jens Pots <[email protected]> Co-authored-by: Orhun Parmaksız <[email protected]> Co-authored-by: Chris Walsh <[email protected]> Co-authored-by: Maxime-J <[email protected]> Co-authored-by: RikoDEV <[email protected]> Co-authored-by: Kevin Van Ryckegem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Concerning MySQL, tables on a fresh install are now created with
utf8mb4_unicode_cicollation (and utf8mb4 charset)I wonder if that's intended?
Because you stated not so much time ago about that #786
and there's no conversion/migration for the already created
utf8_general_citables.I don't know much about the consequences it might have on umami, but switching to utf8mb4 also implies some lengths concerns.
For reference, here is an interesting link
https://mathiasbynens.be/notes/mysql-utf8mb4
(with a side note that the 767 bytes length limit for index has since been increased in newer MySQL versions)
The text was updated successfully, but these errors were encountered: