add cloud_mode #1567
Merged
add cloud_mode #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
❌ Deploy Preview for heartfelt-souffle-72e1df failed.
|
mikecao
requested changes
Oct 12, 2022
There was a problem hiding this comment.
I don't like the idea of passing settingsDisabled down the chain. It's hard to follow. Just create a build time env var and check that where needed.
Also if you hit a restricted page in should just stop. It doesn't need to render anything. No need to pass anything.
components/layout/Header.js
Outdated
| </div> | ||
| )} | ||
| <div className={styles.buttons}> | ||
| <ThemeButton /> | ||
| <LanguageButton menuAlign="right" /> | ||
| {user && <UserButton />} | ||
| {user && <UserButton settingsDisabled={settingsDisabled} />} |
There was a problem hiding this comment.
Makes no sense to pass this prop. Just check and don't show the button.
components/settings/UserButton.js
Outdated
| @@ -9,7 +9,7 @@ import styles from './UserButton.module.css'; | |||
| import { AUTH_TOKEN } from 'lib/constants'; | |||
| import useUser from 'hooks/useUser'; | |||
|
|
|||
| export default function UserButton() { | |||
| export default function UserButton({ settingsDisabled }) { | |||
There was a problem hiding this comment.
This entire button should be hidden.
mikecao
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hide app functionality based on cloud_mode