pass in parameters needed to member service

[Bakersbakebread]

Creating a member with identity needs name and email to be passed in.

The PR fixes this by passing in the parameters rather than string.Empty

[github-actions]

Hi there @Bakersbakebread, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Zeegaan]

How this was tested

I created my own NotificationHandler, that would save a member whenever i tried to save a document type.

using Umbraco.Cms.Core.Composing;
using Umbraco.Cms.Core.Events;
using Umbraco.Cms.Core.Notifications;
using Umbraco.Cms.Core.Services;

namespace Umbraco.Cms.Web.UI;

public class NotificationTest : INotificationHandler<ContentTypeSavedNotification>
{
    private readonly IMemberService _memberService;

    public NotificationTest(IMemberService memberService)
    {
        _memberService = memberService;
    }
    public void Handle(ContentTypeSavedNotification notification)
    {
        _memberService.CreateMemberWithIdentity("Nikolaj", "[email protected]", "Nikolaj", "Member");
    }
}

public class MyComposer : IComposer
{
    public void Compose(IUmbracoBuilder builder)
    {
        builder.AddNotificationHandler<ContentTypeSavedNotification, NotificationTest>();
    }
}

[Zeegaan]

Thank you for this fix & congratulations on your first PR @Bakersbakebread 🎉

[bjarnef]

@Zeegaan this also seems to be inconsistent where username is passed in a name while another method use string.Empty
https://github.com/Bakersbakebread/Umbraco-CMS/blob/56abcc95c5a744b060c4cae977bc5d29454aa008/src/Umbraco.Core/Services/MemberService.cs#L173-L180

[Zeegaan]

@bjarnef You are totally right.
It's not part of the interface though, and now that I'm noticing it, the method on Line 176 (that was fixed in this pr) is not either 🤔
I will look into this 🕵️

[bjarnef]

@Zeegaan the changes in this PR was only fixing the methods with name parameters.
I was looking at the methods without name parameter but username parameter. In one of these username is used as name in the other just an empty string.

[Zeegaan]

@bjarnef Yep needs to be fixed 👍
I'm just trying to figure out why that method is not part of the IMemberService interface 🙈

[mikecp]

Congratulations on your first PR, @Bakersbakebread 👍🎉
If you provide us your account name on Our, @nul800sebastiaan will be happy to assign our shiny contributor's badge to you 🥇

I'm looking forward to your next one (also during CoceCabin maybe😁?)

Cheers!