-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Current User Group Id Condition #18011
Merged
iOvergaard
merged 14 commits into
v15/dev
from
v15/feature/current-user-group-condition
Jan 17, 2025
Merged
V15: Current User Group Id Condition #18011
iOvergaard
merged 14 commits into
v15/dev
from
v15/feature/current-user-group-condition
Jan 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I shared a few thoughts on the config options to Jacob in a Slack message. So we have a conversation going and why i assigned my self as the reviewer :-) |
match, oneOf, allOf, noneOf
…ation across user models
...braco.Web.UI.Client/src/packages/user/current-user/conditions/group-id/group-id.condition.ts
Outdated
Show resolved
Hide resolved
src/Umbraco.Web.UI.Client/src/packages/user/current-user/types.ts
Outdated
Show resolved
Hide resolved
nielslyngsoe
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, we could use a unit-test for this, but in relation to all the things we still havn't tested I accept it :-)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a grant/deny type condition to check for the current user's user group id's.
Usage:
To accomplish this, a Set of user group IDs has also been added to the current user model in the Management API. They were already present on the user factory, so linking the properties up works.