✨ enabled speedy mode by default (#2373)

umijs · Jan 12, 2023 · 141d868 · 141d868 · vercel · Jan 12, 2023
1 parent 68d0e12
commit 141d868
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/__tests__/utils.test.ts b/src/__tests__/utils.test.ts
@@ -26,13 +26,13 @@ it('should wrap the id [2]', () => {
 
 it('should wrap string with div', () => {
   const tpl = '<span>qiankun</span>';
-  const factory = getDefaultTplWrapper('react16');
+  const factory = getDefaultTplWrapper('react16', { speedy: true });
 
   const ret = factory(tpl);
 
   expect(ret).toBe(
     // eslint-disable-next-line max-len
-    `<div id="__qiankun_microapp_wrapper_for_react_16__" data-name="react16" data-version="${version}"><qiankun-head></qiankun-head>${tpl}</div>`,
+    `<div id="__qiankun_microapp_wrapper_for_react_16__" data-name="react16" data-version="${version}" data-sandbox-configuration="{\"speedy\":true}"><qiankun-head></qiankun-head>${tpl}</div>`,
   );
 });
 

diff --git a/src/loader.ts b/src/loader.ts
@@ -272,7 +272,7 @@ export async function loadApp<T extends ObjectType>(
     await (prevAppUnmountedDeferred && prevAppUnmountedDeferred.promise);
   }
 
-  const appContent = getDefaultTplWrapper(appInstanceId)(template);
+  const appContent = getDefaultTplWrapper(appInstanceId, sandbox)(template);
 
   const strictStyleIsolation = typeof sandbox === 'object' && !!sandbox.strictStyleIsolation;
 
@@ -311,7 +311,8 @@ export async function loadApp<T extends ObjectType>(
   let mountSandbox = () => Promise.resolve();
   let unmountSandbox = () => Promise.resolve();
   const useLooseSandbox = typeof sandbox === 'object' && !!sandbox.loose;
-  const speedySandbox = typeof sandbox === 'object' && !!sandbox.speedy;
+  // enable speedy mode by default
+  const speedySandbox = typeof sandbox === 'object' ? sandbox.speedy !== false : true;
   let sandboxContainer;
   if (sandbox) {
     sandboxContainer = createSandboxContainer(

diff --git a/src/utils.ts b/src/utils.ts
@@ -130,7 +130,7 @@ export function isBoundedFunction(fn: CallableFunction) {
 
 export const qiankunHeadTagName = 'qiankun-head';
 
-export function getDefaultTplWrapper(name: string) {
+export function getDefaultTplWrapper(name: string, sandboxOpts: FrameworkConfiguration['sandbox']) {
   return (tpl: string) => {
     let tplWithSimulatedHead: string;
 
@@ -146,7 +146,9 @@ export function getDefaultTplWrapper(name: string) {
 
     return `<div id="${getWrapperId(
       name,
-    )}" data-name="${name}" data-version="${version}">${tplWithSimulatedHead}</div>`;
+    )}" data-name="${name}" data-version="${version}" data-sandbox-configuration="${JSON.stringify(
+      sandboxOpts,
+    )}">${tplWithSimulatedHead}</div>`;
   };
 }