optimize(sandbox): remove object spread operator for faster performan…

…ce in big array iterator

packages/sandbox/src/core/membrane/index.ts

@@ -11,6 +11,7 @@ import {
 import { nativeGlobal } from '../../consts';
 import { isPropertyFrozen } from '../../utils';
 import { globalsInBrowser } from '../globals';
+import { array2TruthyObject } from '../utils';
 import { rebindTarget2Fn } from './utils';
 
 declare global {
@@ -59,9 +60,9 @@ const isPropertyDescriptor = (v: unknown): boolean => {
   );
 };
 
-const cachedGlobalsInBrowser = globalsInBrowser
-  .concat(process.env.NODE_ENV === 'test' ? ['mockNativeWindowFunction'] : [])
-  .reduce<Record<string, true>>((acc, key) => ({ ...acc, [key]: true }), Object.create(null) as Record<string, true>);
+const cachedGlobalsInBrowser = array2TruthyObject(
+  globalsInBrowser.concat(process.env.NODE_ENV === 'test' ? ['mockNativeWindowFunction'] : []),
+);
 const isNativeGlobalProp = (prop: string): boolean => {
   return prop in cachedGlobalsInBrowser;
 };
@@ -174,7 +175,6 @@ export class Membrane {
       // trap in operator
       // see https://github.com/styled-components/styled-components/blob/master/packages/styled-components/src/constants.js#L12
       has(membraneTarget: MembraneTarget, p: string | number | symbol): boolean {
-        // property in cachedGlobalObjects must return true to avoid escape from get trap
         return p in membraneTarget || p in incubatorContext;
       },
 

packages/sandbox/src/core/membrane/utils.ts

@@ -59,10 +59,15 @@ export function rebindTarget2Fn<T>(target: unknown, fn: T, receiver: unknown): T
           'toString',
         );
 
-        Object.defineProperty(boundValue, 'toString', {
-          ...originToStringDescriptor,
-          ...(originToStringDescriptor?.get ? null : { value: () => typedValue.toString() }),
-        });
+        Object.defineProperty(
+          boundValue,
+          'toString',
+          Object.assign(
+            {},
+            originToStringDescriptor,
+            originToStringDescriptor?.get ? null : { value: () => typedValue.toString() },
+          ),
+        );
       }
     }
 

packages/sandbox/src/core/sandbox/StandardSandbox.ts

@@ -4,6 +4,7 @@ import { Compartment } from '../compartment';
 import { globalsInES2015 } from '../globals';
 import type { Endowments } from '../membrane';
 import { Membrane } from '../membrane';
+import { array2TruthyObject } from '../utils';
 import type { Sandbox } from './types';
 import { SandboxType } from './types';
 
@@ -77,14 +78,7 @@ export class StandardSandbox extends Compartment implements Sandbox {
 
     const constantNames = Array.from(new Set(Object.keys(intrinsics).concat(globalsInES2015).concat(whitelistBOMAPIs)));
     // intrinsics should not be escaped from sandbox
-    const unscopables = without(constantNames, ...Object.keys(intrinsics)).reduce(
-      (acc, key) => ({ ...acc, [key]: true }) as Record<string, true>,
-      // Notes that babel will transpile spread operator to Object.assign({}, ...args), which will keep the prototype of Object in merged object,
-      // while this result used as Symbol.unscopables, it will make properties in Object.prototype always be escaped from proxy sandbox as unscopables check will look up prototype chain as well,
-      // such as hasOwnProperty, toString, valueOf, etc.
-      // so we should use Object.create(null) to create a pure object without prototype chain here.
-      Object.create(null) as Record<string, true>,
-    );
+    const unscopables = array2TruthyObject(without(constantNames, ...Object.keys(intrinsics)));
     const membrane = new Membrane(incubatorContext, unscopables, {
       whitelist: [],
       endowments: { ...intrinsics, ...globals },

packages/sandbox/src/core/utils.ts

@@ -0,0 +1,21 @@
+/**
+ * @author Kuitos
+ * @since 2023-11-15
+ */
+/**
+ * transform the array to a truthy object for better performance with in operator check later
+ * @param array
+ */
+export function array2TruthyObject(array: string[]): Record<string, true> {
+  return array.reduce(
+    (obj, key) => {
+      obj[key] = true;
+      return obj;
+    },
+    // Notes that babel will transpile spread operator to Object.assign({}, ...args), which will keep the prototype of Object in merged object,
+    // while this result used as Symbol.unscopables, it will make properties in Object.prototype always be escaped from proxy sandbox as unscopables check will look up prototype chain as well,
+    // such as hasOwnProperty, toString, valueOf, etc.
+    // so we should use Object.create(null) to create a pure object without prototype chain here.
+    Object.create(null) as Record<string, true>,
+  );
+}