✨ hijack the dynamic stylesheet injection during development phase #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howel52
approved these changes
Nov 4, 2019
Ariel-Cheng
reviewed
Nov 5, 2019
| freers.forEach(free => sideEffectsRebuilders.push(free())); | ||
| freers = []; | ||
| // note that the frees of mounting phase are one-off as it will be re-init at next mounting | ||
| sideEffectsRebuilders = [...bootstrappingFreers, ...mountingFreers].map(free => free()); |
Ariel-Cheng
reviewed
Nov 5, 2019
| // for gc | ||
| dynamicStyleSheets = []; | ||
| if (!bootstrapping) { | ||
| // for gc |
There was a problem hiding this comment.
因为 bootstrapping 阶段拦截到的副作用会被多次 rebuild
Ariel-Cheng
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
针对 bootstrap 阶段添加的副作用 (如 style-loader 在应用 mount 前动态插入的样式) 的处理
close #118
This change is