Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ add getContainerXPath test #2132

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

liaohainan
Copy link
Contributor

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
  • add getContainerXPath test

@vercel
Copy link

vercel bot commented Jun 5, 2022

@liaohainan is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

@liaohainan liaohainan force-pushed the add_mark_for_getContainerXPath branch from 96286bb to 571ded6 Compare June 6, 2022 13:57
kuitos
kuitos previously approved these changes Jun 15, 2022
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos
Copy link
Member

kuitos commented Jun 15, 2022

ci failed

@liaohainan
Copy link
Contributor Author

ci failed

already fixed

@kuitos kuitos merged commit 7d0116c into umijs:master Sep 26, 2022
stefango pushed a commit to stefango/qiankun that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants