Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an important detail for react's doc #2178

Merged
merged 3 commits into from
Sep 26, 2022
Merged

add an important detail for react's doc #2178

merged 3 commits into from
Sep 26, 2022

Conversation

ygcedu
Copy link
Contributor

@ygcedu ygcedu commented Jul 8, 2022 •
edited
Loading

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@vercel
Copy link

vercel bot commented Jul 8, 2022

@ygcedu is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

@kuitos kuitos requested a review from gongshun July 12, 2022 08:08
kuitos
kuitos approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos kuitos merged commit 426b0dd into umijs:master Sep 26, 2022
stefango pushed a commit to stefango/qiankun that referenced this pull request Jul 11, 2023
@ygcedu
📝 add an important detail for react's doc (umijs#2178)
10758c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gongshun gongshun gongshun approved these changes

@kuitos kuitos kuitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ygcedu @kuitos @gongshun