Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 should keep the property writable while it only have setter accessor #2302

Merged
merged 1 commit into from
Oct 13, 2022
Merged

🐛 should keep the property writable while it only have setter accessor #2302

merged 1 commit into from
Oct 13, 2022

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Oct 13, 2022 •
edited
Loading

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@vercel
Copy link

vercel bot commented Oct 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
qiankun ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 1:32PM (UTC)

@kuitos kuitos merged commit 9df1bf9 into master Oct 13, 2022
@kuitos kuitos deleted the fix/readonly-property-not-writable branch October 13, 2022 13:37
stefango pushed a commit to stefango/qiankun that referenced this pull request Jul 11, 2023
@kuitos
🐛 should keep the property writable while it only have setter accessor (
8c00121 
umijs#2302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

最新2.8.2版本对部分框架打包的子应用兼容有问题
1 participant
@kuitos