-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed the problem that the cssText attribute cannot be obtained … #2532
Conversation
@aique127 is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel. @umijs first needs to authorize it. |
期待早日合并:) |
src/sandbox/patchers/css.ts
Outdated
@@ -102,7 +102,12 @@ export class ScopedCSS { | |||
css += this.ruleSupport(rule as CSSSupportsRule, prefix); | |||
break; | |||
default: | |||
css += `${rule.cssText}`; | |||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议这里 try catch,可以参考这个方案修复 https://github.com/gregnb/react-to-print/pull/99/files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经重新提交了:)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kuitos 大佬,我重新提交了。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work~
Checklist
npm test
passesDescription of change
fix: Fixed the problem that the cssText attribute cannot be obtained when @keyfram has a -webkit prefix style in IE11
ie11环境下,当@Keyframe带有-webkit-私有前缀时,使用cssRules获取不到cssText导致报错: 找不到成员。
例如使用autoprefixe插件自动添加前缀
希望能在qiankun代码里进行错误捕获。防止获取cssText报错