Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create-qiankun #2700

Merged
merged 73 commits into from
Jan 4, 2024
Merged

feat: create-qiankun #2700

merged 73 commits into from
Jan 4, 2024

Conversation

hakushinring
Copy link

qiankun cli 初始化目录

@changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2023

🦋 Changeset detected

Latest commit: 1bdeef3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 26, 2023

@hakushinring is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

@hakushinring hakushinring changed the base branch from master to next September 26, 2023 02:47
@aladdin-add aladdin-add marked this pull request as draft September 28, 2023 05:41
@aladdin-add aladdin-add changed the title Feat/create qiankun feat: create-qiankun Sep 28, 2023
@qiYuei
Copy link
Contributor

qiYuei commented Oct 17, 2023

@kuitos @hakushinring @aladdin-add

各位大佬可以看看第一版功能,是否有东西需要添加,或者修改的
本地使用可看 readme.md

目前完成

  • 创建主应用和多个子应用,可选多仓库管理或者单仓库管理
  • 选用 pnpm+workspace 做为包管理使用提供 启动应用脚本和 pnpm检查
  • 创建应用随机生成端口号
  • 主子应用一起创建时注入子应用信息至 主应用

待完成

  • 应用启动端口号冲突检查
  • 单仓库管理提供脚本 启动应用、安装依赖等
  • 待添加 umi vite 相关模板

@kuitos
Copy link
Member

kuitos commented Oct 18, 2023

template 里好像没看到 react 的主应用?

@hakushinring
Copy link
Author

@kuitos cli 包名能不能去掉 @qiankunjs/ 这个scope 。 这样用户用的时候就可以用下面这种方式使用

npm create qiankun 
npm init qiankun

package name已经改为 create-qiankun

@@ -0,0 +1,5 @@
---
"@qiankunjs/create-qiankun": patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"@qiankunjs/create-qiankun": patch
"create-qiankun": patch

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我重新add一下,版本号是不是应该先改成rc版发个测试

@qiYuei
Copy link
Contributor

qiYuei commented Dec 25, 2023

那跟他们保持一致好了

那现在如果要发布测试,webpack-plugin react/vue qiankun 这些填啥版本呢。还是等你吧这些全发布后,cli再发布

@kuitos
Copy link
Member

kuitos commented Dec 25, 2023

填现在最新的版本就行吧?写 ^ 匹配的话不影响吧

@aladdin-add
Copy link
Contributor

aladdin-add commented Dec 26, 2023

最新的lockfile格式是 6.0: https://github.com/pnpm/spec/blob/master/lockfile/6.0.md.

但是这个分支里面是 6.1,不知道什么怎么生成的。🤷

@kuitos
Copy link
Member

kuitos commented Dec 26, 2023

那现在如果要发布测试,webpack-plugin react/vue qiankun 这些填啥版本呢。还是等你吧这些全发布后,cli再发布

发掉了

@kuitos
Copy link
Member

kuitos commented Dec 26, 2023

但是这个分支里面是 6.1,不知道什么怎么生成的。🤷

本地 pnpm 版本的问题吧?https://github.com/orgs/pnpm/discussions/6857

@aladdin-add
Copy link
Contributor

我本地升级到最新的版本,重新安装也没有变化。可能是之前某个版本的bug,在后来某个patch版本修复掉了,但是之前版本更新过的lockfile被提交了。。 😂

@aladdin-add
Copy link
Contributor

可能的解决方案:

  1. 在 ci 里面 pnpm install --no-frozen-lockfile
  2. 撤销掉之前出问题的提交,重新执行 pnpm install
  3. 删除掉 pnpm-lock.yaml,重新执行 pnpm install来生成(可能会更新某些依赖版本, e.g "^1.0.0" => "1.y.z")

@kuitos
Copy link
Member

kuitos commented Dec 26, 2023

重新生成一个好了

@qiYuei
Copy link
Contributor

qiYuei commented Dec 27, 2023

重新生成一个好了

Done

Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos
Copy link
Member

kuitos commented Jan 4, 2024

是不是可以合了? @hakushinring @qiYuei @aladdin-add

@qiYuei
Copy link
Contributor

qiYuei commented Jan 4, 2024

是不是可以合了? @hakushinring @qiYuei @aladdin-add

我觉得可以了,发布个 rc 测试看看

@kuitos kuitos merged commit 4c7a773 into umijs:next Jan 4, 2024
5 of 6 checks passed
@kuitos kuitos linked an issue Feb 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] 微应用脚手架 cli
4 participants