Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💚 fix docs build error #2718

Merged
merged 2 commits into from
Oct 10, 2023
Merged

💚 fix docs build error #2718

merged 2 commits into from
Oct 10, 2023

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Oct 10, 2023 •
edited
Loading

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 29975b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 6:34am

@kuitos kuitos mentioned this pull request Oct 10, 2023
Merged
@kuitos
Copy link
Member Author

kuitos commented Oct 10, 2023

还是失败，有点问题

@kuitos
Copy link
Member Author

kuitos commented Oct 10, 2023

成功了 @aladdin-add

@kuitos kuitos requested a review from aladdin-add October 10, 2023 06:37
@kuitos kuitos linked an issue Oct 10, 2023 that may be closed by this pull request
部署 Vercel 权限问题 #2714
Closed
@kuitos kuitos merged commit f0bda28 into next Oct 10, 2023
@kuitos kuitos deleted the fix/docs-build branch October 10, 2023 06:44
@aladdin-add aladdin-add mentioned this pull request Oct 10, 2023
Closed
bravepg
bravepg reviewed Oct 10, 2023
View reviewed changes
package.json
},
"type": "module",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type module 干掉了，是不是很多 .cjs 结尾的文件也都改回 .js？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个主要是不删 dumi 构建会报错，不知道 dumi2 是不是已经支持了？ @PeachScript

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该不影响吧，dumi 1 可能是因为 webpack 4 的关系？可以顺便升级到 dumi 2 试试看

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的，webpack4 导致的，我试试升到 dumi2 先

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2720 不行，exportStatic.js require umi.server.js 时，会识别成 esm 导致报错
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bravepg bravepg bravepg left review comments

@PeachScript PeachScript PeachScript left review comments

@aladdin-add aladdin-add Awaiting requested review from aladdin-add

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

部署 Vercel 权限问题
3 participants
@kuitos @PeachScript @bravepg