Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add contributing guide #2732

Merged
merged 1 commit into from
Oct 30, 2023
Merged

docs: add contributing guide #2732

merged 1 commit into from
Oct 30, 2023

Conversation

aladdin-add
Copy link
Contributor

@aladdin-add aladdin-add commented Oct 16, 2023 •
edited
Loading

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd12cc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2023

@aladdin-add is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

@aladdin-add aladdin-add force-pushed the docs/add-contributing branch 2 times, most recently from f2cdc00 to e01824b Compare October 16, 2023 03:04
kuitos
kuitos reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice~ 英文版本也来一个？

@aladdin-add
Copy link
Contributor Author

先看一下中文的，没问题的话再让chatgpt 翻译一个 :)

@kuitos
Copy link
Member

kuitos commented Oct 16, 2023

commit msg 规范补充一个？用 Conventional Commits 规范就行

@aladdin-add
Copy link
Contributor Author

但是qiankun貌似是用了 emoj - 不是很熟悉，需要什么配置么？

@kuitos
Copy link
Member

kuitos commented Oct 16, 2023

后面统一成Conventional Commits就好了，emoji是我个人喜好

@aladdin-add aladdin-add force-pushed the docs/add-contributing branch from e01824b to fcbb3ca Compare October 23, 2023 08:07
@aladdin-add aladdin-add marked this pull request as ready for review October 23, 2023 08:08
@aladdin-add aladdin-add requested a review from kuitos October 23, 2023 08:10
@aladdin-add aladdin-add force-pushed the docs/add-contributing branch 2 times, most recently from 4a5e26c to 09f7789 Compare October 23, 2023 08:37
kuitos
kuitos reviewed Oct 23, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@aladdin-add aladdin-add force-pushed the docs/add-contributing branch from 09f7789 to 77ebc8b Compare October 23, 2023 10:15
@aladdin-add aladdin-add force-pushed the docs/add-contributing branch from 77ebc8b to fd12cc0 Compare October 23, 2023 10:16
@aladdin-add aladdin-add requested a review from kuitos October 25, 2023 01:52
kuitos
kuitos approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work~

@kuitos kuitos merged commit 7715b0d into umijs:next Oct 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuitos kuitos kuitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aladdin-add @kuitos