Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛not rebind non-native global properties #2733

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Oct 16, 2023

Checklist
  • npm test passes
  • tests are included
  • commit message follows commit guidelines
Description of change

@changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2023

⚠️ No Changeset found

Latest commit: 983f0c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 6:49am

@mmmmmmmgo
Copy link

mmmmmmmgo commented Oct 28, 2024

这个PR, 引入了白名单, 如果用户就是用到了一个新的浏览器api,但是不在白名单,就可能报错。
所以这个库要经常更新globalsInBrowser? 而且globals这个npm包也要经常更新?

为什么JS语言的白名单是globalsInES2015,不应该尽可能最新吗?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants