Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sandbox): set proxy appendChild/insertBefore method for every sandbox rather than modify prototype on HTMLElement #2736

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Oct 19, 2023

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2023

🦋 Changeset detected

Latest commit: 86a68fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@qiankunjs/sandbox Patch
@qiankunjs/loader Patch
qiankun Patch
@qiankunjs/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 10:06am

@kuitos kuitos changed the title feat: set proxy appendChild/insertBefore method for every sandbox rat… feat: set proxy appendChild/insertBefore method for every sandbox rather than modify prototype on HTMLElement Oct 19, 2023
@kuitos kuitos changed the title feat: set proxy appendChild/insertBefore method for every sandbox rather than modify prototype on HTMLElement feat(sandbox): set proxy appendChild/insertBefore method for every sandbox rather than modify prototype on HTMLElement Oct 19, 2023
@kuitos kuitos merged commit 488447a into next Oct 19, 2023
4 checks passed
@kuitos kuitos deleted the feat/new-document-appendchild branch October 19, 2023 11:15
@kuitos kuitos mentioned this pull request Oct 19, 2023
3 tasks
@kuitos kuitos linked an issue Oct 19, 2023 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] 3.0 loader bug
1 participant