Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pre-commit #2750

Merged
merged 1 commit into from
Oct 23, 2023
Merged

chore: add pre-commit #2750

merged 1 commit into from
Oct 23, 2023

Conversation

aladdin-add
Copy link
Contributor

已经有了 lint-staged, 但是并没有在pre-commit时执行,很容易忘记执行,
所以添加了pre-commit

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

⚠️ No Changeset found

Latest commit: fa4dc2a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023

@aladdin-add is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

已经有了 lint-staged, 但是并没有在pre-commit时执行,很容易忘记执行,
所以添加了pre-commit
@aladdin-add
Copy link
Contributor Author

之前已经有了,只是被注释了 :)

@aladdin-add aladdin-add marked this pull request as ready for review October 23, 2023 08:46
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos kuitos merged commit d1b3eec into umijs:next Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants