Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should patch the container head/body element immediately rather than patch its functions with proxy #2752

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Oct 23, 2023

直接修改 container 里的 qiankun head 元素,为其增加 appendChild 等方法,这样即便用户是通过 parentNode 这类方式一层层获取到 head 元素的,也可以确保后续的 appendChild 等操作一定会被代理

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 2dbe821

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@qiankunjs/sandbox Patch
@qiankunjs/loader Patch
qiankun Patch
@qiankunjs/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 3:05pm

@kuitos kuitos merged commit 3d1d336 into next Oct 23, 2023
4 checks passed
@kuitos kuitos deleted the fix/dynamic-append branch October 23, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant