Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: createElement hijack must be paired to avoid rewriting leak #2777

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

kuitos
Copy link
Member

@kuitos kuitos commented Nov 2, 2023

当子应用复写了 document.createElement 的时候,会导致全局的 document.createElement 也被改写,从而导致主应用的元素创建也被视为子应用,比如子应用中这样一段代码:

const nativeCreateElement = document.createElement;
document.createElement = (...args) => {
  return nativeCreateElement.call(document, ...args);
}

Copy link

changeset-bot bot commented Nov 2, 2023

⚠️ No Changeset found

Latest commit: ad73898

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 1:11pm

@kuitos kuitos requested a review from bravepg November 2, 2023 08:29
@kuitos kuitos changed the title fix: createElement rewriting must be proxy as same as reading to avoid global leak fix: createElement hijack must be paired to avoid global leak Nov 2, 2023
@kuitos kuitos changed the title fix: createElement hijack must be paired to avoid global leak fix: createElement hijack must be paired to avoid rewriting leak Nov 2, 2023
@kuitos kuitos merged commit a38b1af into master Nov 2, 2023
4 checks passed
@kuitos kuitos deleted the fix/createelement branch November 2, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant