feat: optimize lifecycle validation log

.changeset/gorgeous-planets-join.md

@@ -0,0 +1,7 @@
+---
+'qiankun': patch
+'@qiankunjs/sandbox': patch
+'@qiankunjs/shared': patch
+---
+
+feat: optimize lifecycle validate log

.changeset/long-radios-admire.md

@@ -0,0 +1,6 @@
+---
+"qiankun": patch
+"@qiankunjs/shared": patch
+---
+
+feat: add lifecycle check log at development environment

packages/qiankun/src/core/loadApp.ts

@@ -6,7 +6,13 @@ import type { LoaderOpts } from '@qiankunjs/loader';
 import { loadEntry } from '@qiankunjs/loader';
 import type { Sandbox } from '@qiankunjs/sandbox';
 import { createSandboxContainer } from '@qiankunjs/sandbox';
-import { moduleResolver as defaultModuleResolver, transpileAssets, wrapFetchWithCache } from '@qiankunjs/shared';
+import {
+  moduleResolver as defaultModuleResolver,
+  getValueType,
+  transpileAssets,
+  warn,
+  wrapFetchWithCache,
+} from '@qiankunjs/shared';
 import { concat, isFunction, mergeWith } from 'lodash';
 import type { ParcelConfigObject } from 'single-spa';
 import getAddOns from '../addons';
@@ -207,37 +213,45 @@ function getLifecyclesFromExports(
   globalContext: WindowProxy,
   globalLatestSetProp?: PropertyKey,
 ): MicroAppLifeCycles {
-  const validateExportLifecycle = (exports: ObjectType | undefined): boolean => {
-    const { bootstrap, mount, unmount } = exports ?? {};
-    return isFunction(bootstrap) && isFunction(mount) && isFunction(unmount);
+  const exportsWarningMsg: string[] = [];
+  const validateExportLifecycle = (exports: ObjectType | undefined, exportsSource: string): boolean => {
+    const validateLifecycleKeys = ['bootstrap', 'mount', 'unmount'];
+    const illegalKeys = validateLifecycleKeys.filter((key) => !isFunction(exports?.[key]));
+    const illegalExports = illegalKeys.length > 0;
+    if (illegalExports) {
+      exportsWarningMsg.push(
+        `${exportsSource} not provide legal lifecycle function found {${illegalKeys
+          .map((key) => `${key}: ${getValueType(exports?.[key])}`)
+          .join(',')}}`,
+      );
+    }
+    return !illegalExports;
   };
 
-  if (validateExportLifecycle(scriptExports)) {
+  if (validateExportLifecycle(scriptExports, 'entry')) {
     return scriptExports;
   }
 
   // fallback to sandbox latest set property if it had
   if (globalLatestSetProp) {
     const lifecycles = (globalContext as unknown as ObjectType)[globalLatestSetProp as never] as MicroAppLifeCycles;
-    if (validateExportLifecycle(lifecycles)) {
+    if (validateExportLifecycle(lifecycles, 'globalLatestSetProp')) {
       return lifecycles;
     }
   }
 
   if (process.env.NODE_ENV === 'development') {
-    console.warn(
-      `[qiankun] lifecycle not found from ${appName} entry exports, fallback to get from window['${appName}']`,
-    );
+    warn(`lifecycle not found from ${appName} entry exports, fallback to get from window['${appName}']`);
   }
 
   // fallback to globalContext variable who named with ${appName} while module exports not found
   const globalVariableExports = (globalContext as unknown as ObjectType)[appName as never] as MicroAppLifeCycles;
 
-  if (validateExportLifecycle(globalVariableExports)) {
+  if (validateExportLifecycle(globalVariableExports, `window['${appName}']`)) {
     return globalVariableExports;
   }
 
-  throw new QiankunError(`You need to export lifecycle functions in ${appName} entry`);
+  throw new QiankunError(`You need to export lifecycle functions at any of ${appName} entry, globalLatestSetProp or window['${appName}']\nmore information: ${exportsWarningMsg.join('\n')}`);
 }
 
 function calcPublicPath(entry: string): string {

packages/sandbox/src/patchers/dynamicAppend/common.ts

@@ -204,7 +204,7 @@ export function getOverwrittenAppendChildOrInsertBefore(
           const result = appendChild.call(this, transpiledScriptElement, refChild) as T;
 
           // the script have no src attribute after transpile, indicating that the script needs to wait for the src to be filled
-          if (externalSyncMode && !transpiledScriptElement.hasAttribute('scr')) {
+          if (externalSyncMode && !transpiledScriptElement.hasAttribute('src')) {
             queueSyncScript!();
           }
 

packages/shared/src/__tests__/util.test.ts

@@ -0,0 +1,21 @@
+import { expect, it } from 'vitest';
+import { getValueType } from '../utils';
+
+it('should return value type', () => {
+  expect(getValueType(1)).toBe('Number');
+  expect(getValueType('1')).toBe('String');
+  expect(getValueType(true)).toBe('Boolean');
+  expect(getValueType(null)).toBe('Null');
+  expect(getValueType(undefined)).toBe('Undefined');
+  expect(getValueType({})).toBe('Object');
+  expect(getValueType([])).toBe('Array');
+  expect(getValueType(function () {})).toBe('Function');
+  expect(getValueType(Symbol())).toBe('Symbol');
+  expect(getValueType(new Date())).toBe('Date');
+  expect(getValueType(new RegExp(''))).toBe('RegExp');
+  expect(getValueType(new Error())).toBe('Error');
+  expect(getValueType(new Map())).toBe('Map');
+  expect(getValueType(new Set())).toBe('Set');
+  expect(getValueType(new WeakMap())).toBe('WeakMap');
+  expect(getValueType(new WeakSet())).toBe('WeakSet');
+});

packages/shared/src/utils.ts

@@ -6,6 +6,7 @@
 // eslint-disable-next-line @typescript-eslint/unbound-method
 export const { create, defineProperty, getOwnPropertyDescriptor, getOwnPropertyNames, freeze, keys } = Object;
 export const hasOwnProperty = (caller: unknown, p: PropertyKey) => Object.prototype.hasOwnProperty.call(caller, p);
+export const getValueType = (value: unknown) => Object.prototype.toString.call(value).slice(8, -1);
 
 export class Deferred<T> {
   promise: Promise<T>;