🐛 dynamic import with custom fetch #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuitos
requested changes
Mar 27, 2020
src/hijackers/dynamicHeadAppend.ts
Outdated
| @@ -2,7 +2,7 @@ | |||
| * @author Kuitos | |||
| * @since 2019-10-21 | |||
| */ | |||
| import { execScripts } from 'import-html-entry'; | |||
| import { execScripts, ExecScriptsOpts } from 'import-html-entry'; | |||
There was a problem hiding this comment.
TS去读取那个模块的根目录下的文件注解了，interface 是导出的
There was a problem hiding this comment.
kuitos
approved these changes
Mar 29, 2020
kuitos
pushed a commit
that referenced
this pull request
Mar 29, 2020
(cherry picked from commit 08043b9)
kuitos
pushed a commit
that referenced
this pull request
Mar 29, 2020
howel52
pushed a commit
that referenced
this pull request
Mar 29, 2020
* 🐛 dynamic import with custom fetch (#347) * ✨ simplify the duplicate loader configuration * 🎨 * 🎨 Co-authored-by: 陶楷 <[email protected]>
kuitos
pushed a commit
that referenced
this pull request
Mar 29, 2020
howel52
pushed a commit
that referenced
this pull request
Mar 29, 2020
* 🐛 dynamic import with custom fetch (#347) * 📝 update doc and correct code * 📝 update doc Co-authored-by: 陶楷 <[email protected]>
kuitos
pushed a commit
that referenced
this pull request
Mar 29, 2020
szy1000
pushed a commit
to szy1000/qiankun
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341
Description of change
透传了
{fetch}参数对象，在子应用采用 dynamic import 时，使用 custom 的 fetch 方法