docs: update english docs #451
Merged
+188
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuitos
requested changes
Apr 18, 2020
| @@ -78,8 +118,6 @@ | |||
| - prefetch - `boolean | 'all' | string[] | (( apps: RegistrableApp[] ) => { criticalAppNames: string[]; minorAppsName: string[] })` - optional, whether to enable prefetch, default is `true`. | |||
|
|
|||
| A configuration of `true` starts prefetching static resources for other subapplications after the first subapplication mount completes. | |||
|
|
|||
There was a problem hiding this comment.
这里应该是中文文档那里被删了..
回滚一下然后把中文那边也补一下？
docs/api/README.md
Outdated
|
|
||
| - activeRule - - `string | (location: Location) => boolean | Array<string | (location: Location) => boolean> ` - required,activation rules for micro-apps. | ||
|
|
||
| * Support direct configuration of string or string array, such as `activeRule: '/ app1'` or `activeRule: [' / app1 ',' / app2 ']`, when configured as a string, it will directly follow the path part in the url Do a prefix match. A successful match indicates that the current application will be activated. |
There was a problem hiding this comment.
还有这里多了空格
activeRule: [' / app1 ',' / app2 ']
|
已经修改啦~ |
kuitos
approved these changes
Apr 20, 2020
|
Thanks for your great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change
Update the engilsh document for qiankun2.0