Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update script tag to be inside body #464

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Update script tag to be inside body #464

merged 1 commit into from
Apr 20, 2020

Conversation

nothingrealhappen
Copy link
Contributor

@nothingrealhappen nothingrealhappen commented Apr 18, 2020 •
edited
Loading

Checklist
  • npm test passes
  • commit message follows commit guidelines
Description of change

script tag 放在了 body 外面

虽然是个小问题...

@nothingrealhappen
Copy link
Contributor Author

原来是故意设计成这样子的... 打扰了

@howel52 howel52 reopened this Apr 20, 2020
@howel52
Copy link
Collaborator

howel52 commented Apr 20, 2020

原来是故意设计成这样子的... 打扰了

这应该只是我写的时候手抖了。

reopen

@howel52 howel52 merged commit 8e4384b into umijs:master Apr 20, 2020
@nothingrealhappen
Copy link
Contributor Author

@howel52 我发现合并进去之后 demo 无法运行了。。。 你要不要看看？

@howel52
Copy link
Collaborator

howel52 commented Apr 20, 2020 •
edited
Loading

@howel52 我发现合并进去之后 demo 无法运行了。。。 你要不要看看？

我看下， 1.x 还是 2.x ？

@howel52
Copy link
Collaborator

howel52 commented Apr 20, 2020

@LiYaoDong 我刚跑了下 1.x 和 2.x 的主干代码，应该都是 ok 的。

这个 pr 先合了，构建有问题的话提供一个可复现 repo 另开 issue 吧。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howel52 howel52 howel52 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nothingrealhappen @howel52