Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 get polyfill in demo #734

Closed
wants to merge 1 commit into from
Closed

Conversation

howel52
Copy link
Collaborator

@howel52 howel52 commented Jul 6, 2020

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@howel52 howel52 requested review from Deturium and kuitos July 6, 2020 16:23
@kuitos
Copy link
Member

kuitos commented Jul 6, 2020

这个还是落到 FAQ 吧?包括 #296 里的

@howel52
Copy link
Collaborator Author

howel52 commented Jul 6, 2020

🆗

@howel52 howel52 closed this Jul 6, 2020
@@ -4,6 +4,10 @@
<head>
<meta charset="UTF-8">
<title>QianKun Example</title>
<script src="https://cdn.jsdelivr.net/npm/[email protected]/dist/polyfill.min.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

全部引进来是不是有些暴力,最基础的引这么几个就可以的

import 'core-js/stable/promise';
import 'core-js/stable/symbol';
import 'core-js/stable/string/starts-with';
import 'core-js/web/url';

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

准备加在 FAQ 里,这个 PR 先关了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants