🐛 use a ref copy instead to avoid listener traverse disordered while splicing #76

kuitos · 2019-09-16T13:41:32Z

splice the same reference would cause the listener traverse disordered, see

qiankun/src/hijackers/windowListener.ts

Line 25 in 9bdb48a

storedTypeListeners.splice(storedTypeListeners.indexOf(listener), 1);

This change is

…e splicing

🐛 use a refer copy instead to avoid listener traverse disordered whil…

521ca41

…e splicing

kuitos requested a review from howel52 September 16, 2019 13:42

kuitos changed the title ~~🐛 use a refer copy instead to avoid listener traverse disordered while splicing~~ 🐛 use a ref copy instead to avoid listener traverse disordered while splicing Sep 16, 2019

howel52 approved these changes Sep 16, 2019

View reviewed changes

howel52 merged commit 8d53f53 into master Sep 16, 2019

howel52 deleted the bugfix/unlisten branch September 16, 2019 14:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 use a ref copy instead to avoid listener traverse disordered while splicing #76

🐛 use a ref copy instead to avoid listener traverse disordered while splicing #76

kuitos commented Sep 16, 2019 •

edited

Loading

🐛 use a ref copy instead to avoid listener traverse disordered while splicing #76

🐛 use a ref copy instead to avoid listener traverse disordered while splicing #76

Conversation

kuitos commented Sep 16, 2019 • edited Loading

kuitos commented Sep 16, 2019 •

edited

Loading