🎨 add linter/prettier and fix errors #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuitos
requested changes
Sep 30, 2019
src/index.ts
Outdated
| @@ -120,15 +133,15 @@ export function registerMicroApps<T extends object = {}>(apps: Array<Registrable | |||
| async () => render({ appContent, loading: false }), | |||
| async () => execHooksChain(toArray(afterMount), app), | |||
| // initialize the unmount defer after app mounted and resolve the defer after it unmounted | |||
| async () => await validateSingularMode(singularMode, app) ? prevAppUnmountedDeferred = new Deferred<void>() : void 0, | |||
| // eslint-disable-next-line no-return-assign | |||
There was a problem hiding this comment.
no-return-assign 这个规则直接从 lint 里移除吧
src/sandbox.ts
Outdated
| @@ -108,14 +102,15 @@ export function genSandbox(appName: string) { | |||
|
|
|||
| const boundValue = value.bind(target); | |||
| // some callable function has custom fields, we need to copy the enumerable props to boundValue. such as moment function. | |||
| Object.keys(value).forEach(key => boundValue[key] = value[key]); | |||
| Object.keys(value).forEach(key => { | |||
kuitos
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesDescription of change