-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-5-chain): assetModuleFilename key typo in Output Type #12382
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
漫步解析此次更新主要修正了 变更
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/bundler-webpack/compiled/webpack-5-chain/types/index.d.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/bundler-webpack/compiled/webpack-5-chain/types/index.d.ts
感谢 PR ,这个包的 typo 是在源码里出现的,umi 这里只是预打包了依赖,所以要先改源码里的 typo ,然后 umi 重新打包依赖。 之前有人提过这个问题,详见:sorrycc/webpack-chain#5 、#11969 因为拖了比较久了,这周我问下,看看能不能优先解决,后续会将相关 PR 者一并加入 co author 修复提交。 |
Summary by CodeRabbit
assetModuleFilename
方法的错别字。