This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loom's
DownloadUtil.downloadIfChanged
method has historically always passed anAccept-Encoding: gzip
header, but had no functionality to inflate the files if gzipped encoding was actually used. For the longest time Mojang's servers did not serve gzipped files so this never cropped up in practice. But these days they do, so Voldeloom would download stuff likeversion_manifest.json
as a gzipped file, not inflate it, then try to parse it as JSON with the expected results.This was fixed in fabric-loom by modmuss50 in FabricMC@34b771f, I just lazily cherry-picked that implementation. (
HashedDownloadUtil
must have been added some time between the Voldeloom branch point and that commit. because I can't find it.)This won't affect you if you already have the correct files in your Gradle cache, but it does affect new people setting up projects (hi).
I also yeeted the tests because they fail on my machine and I tried
-Dskip.tests=true
but it no worky, and it was blocking publishToMavenLocal. They were designed for fabric 1.14 anyway, no way in hell that they work.