Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

[1.4.7] Inflate downloaded files #1

Merged

Conversation

quat1024
Copy link

@quat1024 quat1024 commented Jul 27, 2022

Loom's DownloadUtil.downloadIfChanged method has historically always passed an Accept-Encoding: gzip header, but had no functionality to inflate the files if gzipped encoding was actually used. For the longest time Mojang's servers did not serve gzipped files so this never cropped up in practice. But these days they do, so Voldeloom would download stuff like version_manifest.json as a gzipped file, not inflate it, then try to parse it as JSON with the expected results.

This was fixed in fabric-loom by modmuss50 in FabricMC@34b771f, I just lazily cherry-picked that implementation. (HashedDownloadUtil must have been added some time between the Voldeloom branch point and that commit. because I can't find it.)

This won't affect you if you already have the correct files in your Gradle cache, but it does affect new people setting up projects (hi).

I also yeeted the tests because they fail on my machine and I tried -Dskip.tests=true but it no worky, and it was blocking publishToMavenLocal. They were designed for fabric 1.14 anyway, no way in hell that they work.

quat1024 added 2 commits July 27, 2022 01:41
This backports FabricMC/fabric-loom/commit/34b771f7447b181c27f7127ec77fda6eb465111a .
@unascribed
Copy link
Owner

thaaaaannnkkk yyyoooouuuu

Also yeah the tests don't work lol

@unascribed unascribed merged commit 1d3de73 into unascribed:1.4.7 Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants