Merge pull request #1756 from unboxed/simplify-workflow-linters

Use a matrix test for linters to reduce boilerplate

.github/workflows/build.yml

@@ -14,30 +14,41 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  brakeman:
-    uses: ./.github/workflows/linters.yml
-    with:
-      brakeman: true
+  linters:
+    name: Linters
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        task:
+          - brakeman
+          - rubocop
+          - biome
+          - erblint
+          - language_versions
+      fail-fast: false
+    env:
+      BUNDLE_WITHOUT: development
+      PUPPETEER_SKIP_DOWNLOAD: true
+      RAILS_ENV: test
 
-  rubocop:
-    uses: ./.github/workflows/linters.yml
-    with:
-      rubocop: true
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v4
 
-  biome:
-    uses: ./.github/workflows/linters.yml
-    with:
-      biome: true
+      - name: Set up Ruby and install gems
+        uses: ruby/setup-ruby@v1
+        with:
+          bundler-cache: true
 
-  erblint:
-    uses: ./.github/workflows/linters.yml
-    with:
-      erblint: true
+      - name: Install Node
+        uses: actions/setup-node@v4
+        with:
+          node-version-file: .node-version
+      - run: yarn install
 
-  language-versions:
-    uses: ./.github/workflows/linters.yml
-    with:
-      language-versions: true
+      - name: Lint with ${{ matrix.task }}
+        run: |
+          bundle exec rake ${{ matrix.task }}
 
   specs:
     uses: ./.github/workflows/testing.yml

bin/verify-language-versions.sh

@@ -0,0 +1,22 @@
+#!/bin/sh
+set -e
+
+NODE_VERSION=$(cat .node-version)
+if ! grep -q "^ARG NODE_VERSION=$NODE_VERSION" docker/ruby/Dockerfile; then
+	echo "Dockerfile has wrong node: $(grep '^ARG NODE_MAJOR' docker/ruby/Dockerfile)" >&2
+	exit 1
+fi
+if ! grep -q "^ARG NODE_VERSION=$NODE_VERSION" Dockerfile.production; then
+	echo "Dockerfile.production has wrong node: $(grep '^ARG NODE_MAJOR' Dockerfile.production)" >&2
+	exit 1
+fi
+
+RUBY_VERSION=$(cat .ruby-version)
+if ! grep -q "^ARG RUBY_VERSION=$RUBY_VERSION" docker/ruby/Dockerfile; then
+	echo "Dockerfile has wrong ruby: $(grep '^FROM ruby:' docker/ruby/Dockerfile)" >&2
+	exit 1
+fi
+if ! grep -q "^ARG RUBY_VERSION=$RUBY_VERSION" Dockerfile.production; then
+	echo "Dockerfile.production has wrong ruby: $(grep '^ARG RUBY_VERSION' Dockerfile.production)" >&2
+	exit 1
+fi

lib/tasks/language-versions.rake

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+
+desc "Ensure language versions match"
+task language_versions: :environment do
+  exit 1 unless system "bin/verify-language-versions.sh"
+end